EdwinTh / padr

Padding of missing records in time series
https://edwinth.github.io/padr/
Other
132 stars 12 forks source link

padr::pad generates a tidyselect lifecycle warning re: dplyr::select/all_of #90

Open tanho63 opened 1 year ago

tanho63 commented 1 year ago

Hi! Cleaning up some internal packages and trying to get rid of some lifecycle warnings, noticed that padr::pad() generates one now as follows:

options(lifecycle_verbosity = "error")
packageVersion("dplyr")
#> [1] '1.1.2'

simple_df <- data.frame(day = as.Date(c('2016-04-01', '2016-04-03')),
                        some_value = c(3,4))

padr::pad(simple_df)
#> Error:
#> ! Using an external vector in selections was deprecated in tidyselect
#>   1.1.0.
#> ℹ Please use `all_of()` or `any_of()` instead.
#>   # Was:
#>   data %>% select(select_index)
#> 
#>   # Now:
#>   data %>% select(all_of(select_index))
#> 
#> See <https://tidyselect.r-lib.org/reference/faq-external-vector.html>.
padr::pad(simple_df, interval = "day")
#> Error:
#> ! Using an external vector in selections was deprecated in tidyselect
#>   1.1.0.
#> ℹ Please use `all_of()` or `any_of()` instead.
#>   # Was:
#>   data %>% select(select_index)
#> 
#>   # Now:
#>   data %>% select(all_of(select_index))
#> 
#> See <https://tidyselect.r-lib.org/reference/faq-external-vector.html>.
Session Info ```r R> sessioninfo::session_info() ─ Session info ────────────────────────────────────────────────────────────── setting value version R version 4.2.0 (2022-04-22) os Ubuntu 18.04.6 LTS system x86_64, linux-gnu ui RStudio language (EN) collate C.UTF-8 ctype C.UTF-8 tz America/Los_Angeles date 2023-07-19 rstudio 2022.07.0+548 Spotted Wakerobin (server) pandoc NA ─ Packages ────────────────────────────────────────────────────────────────── package * version date (UTC) lib source cachem 1.0.8 2023-05-01 [1] CRAN (R 4.2.0) callr 3.7.3 2022-11-02 [1] CRAN (R 4.2.0) cli 3.6.1 2023-03-23 [1] RSPM crayon 1.5.2 2022-09-29 [1] CRAN (R 4.2.0) devtools * 2.4.5 2022-10-11 [1] CRAN (R 4.2.0) digest 0.6.33 2023-07-07 [1] CRAN (R 4.2.0) dplyr 1.1.2 2023-04-20 [1] CRAN (R 4.2.0) ellipsis 0.3.2 2021-04-29 [1] CRAN (R 4.2.0) fansi 1.0.4 2023-01-22 [1] CRAN (R 4.2.0) fastmap 1.1.1 2023-02-24 [1] CRAN (R 4.2.0) fs 1.6.2 2023-04-25 [1] CRAN (R 4.2.0) generics 0.1.3 2022-07-05 [1] CRAN (R 4.2.0) glue 1.6.2 2022-02-24 [1] CRAN (R 4.2.0) htmltools 0.5.5 2023-03-23 [1] CRAN (R 4.2.0) htmlwidgets 1.6.2 2023-03-17 [1] CRAN (R 4.2.0) httpuv 1.6.11 2023-05-11 [1] CRAN (R 4.2.0) later 1.3.1 2023-05-02 [1] CRAN (R 4.2.0) lifecycle 1.0.3 2022-10-07 [1] CRAN (R 4.2.0) magrittr 2.0.3 2022-03-30 [1] CRAN (R 4.2.0) memoise 2.0.1 2021-11-26 [1] CRAN (R 4.2.0) mime 0.12 2021-09-28 [1] CRAN (R 4.2.0) miniUI 0.1.1.1 2018-05-18 [1] CRAN (R 4.2.0) padr 0.6.0 2021-10-01 [2] RSPM (R 4.0.2) pillar 1.9.0 2023-03-22 [1] RSPM pkgbuild 1.3.1 2021-12-20 [2] RSPM (R 4.2.0) pkgconfig 2.0.3 2019-09-22 [1] CRAN (R 4.2.0) pkgload 1.3.2.1 2023-07-08 [1] CRAN (R 4.2.0) prettyunits 1.1.1 2020-01-24 [1] CRAN (R 4.2.0) processx 3.8.2 2023-06-30 [1] CRAN (R 4.2.0) profvis 0.3.7 2020-11-02 [1] CRAN (R 4.2.0) promises 1.2.0.1 2021-02-11 [1] CRAN (R 4.2.0) ps 1.7.5 2023-04-18 [1] CRAN (R 4.2.0) purrr 1.0.1 2023-01-10 [1] CRAN (R 4.2.0) R6 2.5.1 2021-08-19 [1] CRAN (R 4.2.0) Rcpp 1.0.11 2023-07-06 [1] CRAN (R 4.2.0) remotes 2.4.2 2021-11-30 [1] CRAN (R 4.2.0) rlang 1.1.1 2023-04-28 [1] CRAN (R 4.2.0) rstudioapi 0.14 2022-08-22 [1] CRAN (R 4.2.0) sessioninfo 1.2.2 2021-12-06 [1] CRAN (R 4.2.0) shiny 1.7.4.1 2023-07-06 [1] CRAN (R 4.2.0) stringi 1.7.12 2023-01-11 [1] CRAN (R 4.2.0) stringr 1.5.0 2022-12-02 [1] CRAN (R 4.2.0) tibble 3.2.1 2023-03-20 [1] RSPM tidyselect 1.2.0 2022-10-10 [1] CRAN (R 4.2.0) urlchecker 1.0.1 2021-11-30 [1] CRAN (R 4.2.0) usethis * 2.1.6 2022-05-25 [1] CRAN (R 4.2.0) utf8 1.2.3 2023-01-31 [1] CRAN (R 4.2.0) vctrs 0.6.3 2023-06-14 [1] CRAN (R 4.2.0) withr 2.5.0 2022-03-03 [1] CRAN (R 4.2.0) xtable 1.8-4 2019-04-21 [1] CRAN (R 4.2.0) [1] /home/tan/R/x86_64-pc-linux-gnu-library/4.2 [2] /usr/local/lib/R/site-library [3] /usr/lib/R/site-library [4] /usr/lib/R/library ```

(Fix PR inbound, this looks easy enough)

EdwinTh commented 1 year ago

Thank you for your signalling this and providing the PR. I will look into it closesly when time allows.