EdwinVW / dapr-workshop

Workshop that teaches how to apply Dapr to an existing .NET, Java or Python based microservices application.
186 stars 84 forks source link

[Java] Suggestion for Assignment #3 #55

Closed StevenDevelops closed 1 year ago

StevenDevelops commented 1 year ago

For this java tutorial, Assignment #3, the tutorial would be easier to follow if the following 2 steps are swapped, as the current order creates an error initially, and then the error gets resolved in a later step, which can be confusing or misleading to someone following the tutorial:

This step to declare a Spring Bean makes the IDE throw an error should be swapped (or come before) this step to add a constructor to resolve the error

EdwinVW commented 1 year ago

Hi @StevenDevelops. Thanks for your interest in the Dapr workshop.

@mthmulders: can you look into this suggestion?

mthmulders commented 1 year ago

Thanks for bringing this up, @StevenDevelops! I see how this can be confusing. I've changed the order in which participants go through these steps in #56. I'd love to hear your feedback before @EdwinVW merges it :-) - so @EdwinVW, hold your horses please.

StevenDevelops commented 1 year ago

@mthmulders great, will take a look

mthmulders commented 1 year ago

Could be closed with 25e5acd.