Do we really need multiple retries policy setup?

EdwinVW / pitstop

This repo contains a sample application based on a Garage Management System for Pitstop - a fictitious garage. The primary goal of this sample is to demonstrate several software-architecture concepts like: Microservices, CQRS, Event Sourcing, Domain Driven Design (DDD), Eventual Consistency.

Apache License 2.0

1.08k stars 472 forks source link

Do we really need multiple retries policy setup? #70

Closed Urgen-Dorjee closed 4 years ago

Urgen-Dorjee commented 4 years ago

I am just curious, do we really need multiple retry policies setup for initializing a database?

https://github.com/EdwinVW/pitstop/blob/99d2ef6a180e3e9dfc7ddd259532cc4ff7dbf72c/src/WorkshopManagementEventHandler/Program.cs#L59

https://github.com/EdwinVW/pitstop/blob/99d2ef6a180e3e9dfc7ddd259532cc4ff7dbf72c/src/WorkshopManagementEventHandler/DataAccess/DBInitializer.cs#L14

Is it not a redundant line of code? Is there any significant to have same policy in two different places.

Thanks

EdwinVW commented 4 years ago

Yes, this seems redundant. I'll look into it. Thanks!

EdwinVW commented 4 years ago

Fixed this in d5afbc34735abcc706a6ca7f8f0ea7fb13a0ccee.