search

EdyJ / blender-to-unity-fbx-exporter

FBX exporter addon for Blender compatible with Unity's coordinate and scaling system.
MIT License
947 stars 98 forks source link

Fixed compatibility for Blender 3.4 #31

Closed Andazeus closed 11 months ago

EdyJ commented 1 year ago

Hello, thank you for the pull request! Can you please describe briefly the issue, and how the change fixes it?

I see the try/except block around the command that sets the object mode. However, I'm curious about how that fixes the compatibility with 3.4. If switching to object mode fails, which may be related with issue #17, then exporting will likely fail. Can you confirm?

Andazeus commented 1 year ago

Hey there! Sorry about giving little context and replying late. I had fairly little time and a bunch of assets to export and just wanted to getit out the door quickly.

So from what I understand, the issue was just that the switch to object mode throws an error if you already are in object mode. So this was mostly a quick fix to avoid the issue. Of course, you could also instead do a check that checks whether you already are in object mode and only switch when you are not. But I have done dozens of exports with this solution and everything has been working perfectly fine so far.

EdyJ commented 11 months ago

Couldn't reproduce the issue. In Blender 3.4.1 the exporter version 1.3.1 correctly exports the file even when already in object mode.