Edzelf / ESP32Radio-V2

New version of the well known ESP32 Radio. Now optional I2S output!
Apache License 2.0
182 stars 45 forks source link

Displaying the "Mute" flag on the display #126

Open Pako2 opened 9 months ago

Pako2 commented 9 months ago

I noticed the incorrect display of the "Mute" flag on the display. This display is only true if the mute function is controlled by a rotary encoder. On the contrary, in the case of using the remote control or the web interface, the display of the "Mute" flag does not correspond to the actual situation. I could handle this problem myself, but I would like my code to be as little different from the official version as possible. I already have too many of those differences. Then it is very difficult to incorporate the news in the official version into my modified code. I'm not even 100% sure (only 99%) that the described behavior also occurs on devices with the official version of the code... If not, then I'm very sorry for reporting a bug that doesn't exist!

Pako2 commented 9 months ago

In the end, I decided to solve it myself. It worked pretty well, but I found that it didn't really suit me. I arrived at a completely different (actually completely opposite) solution: Before, I didn't like that the word "Mute" was sometimes visible, sometimes not (even though the mute state was selected). Now the word "Mute" (instead of the name of the station or track) is no longer displayed on the display at all. The mute status is sufficiently indicated by the volume indicator. This is far more useful as it is immediately visible when a track or station change occurs during the mute state.