search

Edzelf / ESP32Radio-V2

New version of the well known ESP32 Radio. Now optional I2S output!
Apache License 2.0
183 stars 45 forks source link

bugfix: sd rescan and load on triple click #47

Closed tsctrl closed 2 years ago

tsctrl commented 2 years ago

file.path() not working on platform = espressif32

Edzelf commented 2 years ago

Latest version allows platform = espressif32 as well as "espressif32@3.1.0".

tsctrl commented 2 years ago

@Edzelf changes to get full path is added on arduino version 2.0 or pio v4.0.0 only. old file.name() to get full path will not work anymore

minimum version is v4.0.0 https://github.com/platformio/platform-espressif32/releases/tag/v4.0.0

arduino version 2.0.3 was release few week ago, definitely more stable and less time to figure problem. and still under espressif support. i would suggest radio v2 to be updated to the latest arduino 2.0.3 version to allow esp32 s3 support for new design as esp32 v1 already very old. there is no changes required on the esp radio end. this for hope to support the future existence on this beloved internet radio apps. 👯‍♂️

tsctrl commented 2 years ago

Hi @Edzelf

for this recent change:

ifdef DEC_HELIX_INT

if ESP_ARDUINO_VERSION_MAJOR >= 2

#error Internal DAC will not work in this version of the platform.  Use espressif32@3.1.0.

endif

endif

i did not try but internal dac should work on arduino 2.0.3 as mentioned here: https://github.com/espressif/arduino-esp32/issues/5938

tsctrl commented 2 years ago

closing this, as per solution added. thanks @Edzelf