Edzelf / ESP32Radio-V2

New version of the well known ESP32 Radio. Now optional I2S output!
Apache License 2.0
209 stars 50 forks source link

i2s mode, volume does not work #5

Open skartalov opened 3 years ago

skartalov commented 3 years ago

This is great project , really. The sound output is great!

BUT:

I use I2C mode, I noticed that VOLUME and TONE controls does not work.

Edzelf commented 3 years ago

I hope this was documented. I will check the document.

Ne3Mx commented 3 years ago

Same here with i2s, pressing the rotary encoder mutes the output. volume does not work unfortunately.

The onboard decoding works much better than the VS1053 implementation, with the old VS1053 I had a lot of hisses and pops, new software decoding works flawlessly! Well done!

skartalov commented 3 years ago

I think you can add a potentiometer as divider to set volume and use this method to control the I2S level:

https://youtu.be/n-tRE8psAhw

That would be great, as for the moment lacking of volume control in I2S really makes this wonderful project unusable.

Edzelf commented 2 years ago

Volume setting for I2S and internal DAC should work now.