search

Eein / chocobro

FFXIV Simulator
Do What The F*ck You Want To Public License
2 stars 0 forks source link

Fix Crits #28

Closed chordscollide closed 10 years ago

chordscollide commented 10 years ago

Currently, every once and a while a crit will proc twice, and I can't figure out why it's happening. For example you'll see: 

1 | //Barrage is active along with other DPS buffs
2 | 9.60 - Executing Auto Attack
3 | !!CRIT!! - 9.60 - Auto Attack Deals 215 Damage. Next AA at 12.8
4 | 9.60 - Auto Attack Deals 228 Damage. Next AA at 12.8
5 | !!CRIT!! - !!CRIT!! - 9.60 - Auto Attack Deals 329 Damage. Next AA at 12.8
6 | !!CRIT!! - 10.00 - Windbite is ticking now for 157 Damage - Time Left: 10
7 | !!CRIT!! - !!PROC!! - Bloodletter reset!
8 | 10.00 - Venomous Bite is ticking now for 120 Damage - Time left: 12

First and foremost, one issue is that for some reason, the Crit AA in line 3 did less damage than the normal AA in line 4 which is incorrect. Second, whenever something has !!CRIT!! - !!CRIT!!, not only is it doing 2.25x a normal attack, it is counting as two crits in the reporting. This ties into !!CRIT!! - !!PROC!!, as the proc itself is counting as a crit.

I tried looking over the code and I can't see why it's not functioning correctly except that something is causing it to read the crit code more than once.

chordscollide commented 10 years ago

Fixed in e0021ced09342fdfa2633bab4cdae7204c8fcb90