search

Effect-TS / effect

An ecosystem of tools to build robust applications in TypeScript
https://effect.website
MIT License
7.71k stars 245 forks source link

build error using TS 5.6 #3848

Closed erlangxk closed 3 weeks ago

erlangxk commented 4 weeks ago

What version of Effect is running?

3.10.4

What steps can reproduce the bug?

have dependency of effect ts 3.10.4 and using TS 5.6

What is the expected behavior?

build correctly

What do you see instead?

../../node_modules/.pnpm/effect@3.10.4/node_modules/effect/dist/dts/Utils.d.ts:69:22 - error TS2420: Class 'SingleShotGen<T, A>' incorrectly implements interface 'Generator<T, A, any>'. Type 'SingleShotGen<T, A>' is missing the following properties from type 'Generator<T, A, any>': map, filter, take, drop, and 9 more.

69 export declare class SingleShotGen<T, A> implements Generator<T, A> {



Found 1 error in ../../node_modules/.pnpm/effect@3.10.4/node_modules/effect/dist/dts/Utils.d.ts:69

### Additional information

if build with TS 5.5, it's successful.
IMax153 commented 4 weeks ago

@erlangxk - we had a similar issue in the Effect playground and IIRC upgrading @types/node solved the issue?

But just in case I'm misremembering, I'll ping @gcanti as well :)

gcanti commented 3 weeks ago

IIRC upgrading @types/node solved the issue?

I think so too. Here's the commit: https://github.com/Effect-TS/website/commit/498084968b25ca5e55f92e8510502c355ddbd9cc#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519