Effect-TS / platform

Unified interfaces for common platform-specific services
https://effect.website
MIT License
41 stars 12 forks source link

Avoid versioning problems by using peer dependencies #322

Closed thewilkybarkid closed 11 months ago

thewilkybarkid commented 11 months ago

Dependabot opened a PR (https://github.com/PREreview/coar-notify/pull/3) which sees multiple versions of @effect/platform and @effect/schema, leading to a broken build as they depend on different versions of effect.

While Dependabot shouldn't be getting as far as opening a PR that can't be installed, I'm guessing that using peer dependencies instead would get around this.

changeset-bot[bot] commented 11 months ago

🦋 Changeset detected

Latest commit: 0026467feac45c7332ce4bd258c4b3700527d37b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages | Name | Type | | ------------------------ | ----- | | @effect/platform-browser | Patch | | @effect/platform-node | Patch | | @effect/platform-bun | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

thewilkybarkid commented 11 months ago

Same problem when it tries to update @effect/schema: https://github.com/PREreview/coar-notify/pull/4

tim-smart commented 11 months ago

This has been addressed :)

thewilkybarkid commented 11 months ago

Turns out this doesn't entirely fix Dependabot (https://github.com/PREreview/coar-notify/pull/18). I'm guessing it doesn't update prerelease versions. (As they all pin a version of effect I'd hoped it would do a batch update of all the Effect packages.)