search

Effect-TS / website

Source code for Effect's documentation website
https://www.effect.website
105 stars 85 forks source link

Still uses `@effect-rx/*` #942

Closed lishaduck closed 6 days ago

lishaduck commented 6 days ago

What is the type of issue?

Something else

What is the issue?

It looks like @effect-rx got merged into effect core now (in Effect-TS/effect#3937), so the dependency should be updated, methinks? I was looking through the code for site (just curious), and noticed it.

Where did you find it?

https://github.com/Effect-TS/website/blob/main/content/src/rx/location.ts

IMax153 commented 6 days ago

@lishaduck - @effect-rx and the new Reactivity module in experimental are still two separate things.

Reactivity is a much less feature-rich reactivity primitive than Rx, and is more meant for us to use to experiment with EventLog stuff.

So the TL;DR is that Reactivity does not replace Rx (at least not yet :) ).

lishaduck commented 6 days ago

Ok then! May I ask why github:Effect-TS/rx got deleted? I wanted to read the source, but it was gone, which is why I assumed Reactivity was meant to subsume it.

IMax153 commented 6 days ago

May I ask why github:Effect-TS/rx got deleted?

Of course! That repo never existed :) @effect-rx/rx is a personal repository from the one-and-only Tim Smart - https://github.com/tim-smart/effect-rx