Efferent-Health / fo-dicom.Codecs

Cross-platform Dicom native codecs for fo-dicom
Other
64 stars 22 forks source link

Plan to update the OpenJPEG library #69

Closed jaime-olivares closed 1 month ago

jaime-olivares commented 1 month ago

We have been using a now-outdated version of OpenJPEG (2011) for the last six years. It is not easy to change it because there are specific dependencies between the C# and C++ code, with high sensitivity to changes in method names and signatures. After solving that, we have to test every platform we support (Windows, Linux, macOS, Intel, ARM). During this time, we have received several reports of specific DICOM files failing to decode, that we know are solved in the newest versions of OpenJPEG. It seems it is almost the time for updating the version. It's a bummer that OpenJPEG still doesn't support HTJ2K encoding (read https://github.com/uclouvain/openjpeg/issues/1487) but we hope it will incorporated soon and can be added without impacting our source code significantly.

jaime-olivares commented 1 month ago

Associated branch: https://github.com/Efferent-Health/fo-dicom.Codecs/tree/Upgrade-OpenJPEG-library-to-v2.5.2

cbeltran1306 commented 1 month ago

This enhacement has been included in the new release https://www.nuget.org/packages/fo-dicom.Codecs/5.13.0.