Efimj / Shkiper

Android modern notepad
https://play.google.com/store/apps/details?id=com.jobik.shkiper
163 stars 8 forks source link

Feature: Follow System theme option #75

Open Gukkey opened 2 months ago

Gukkey commented 2 months ago

Currently Shkiper has a toggle for dark and light mode. I suggest adding a "Follow system theme" option along with it. Like either a dropdown or a separate dropdown which if enabled disables dark/light mode toggle.

Let me know if I can make a PR for this. I am new to android dev, but I think I can do this.

Efimj commented 2 months ago

Hey, good idea. I already have all the logic for switching theme.

I think instead of a switch we should make an icon changer. Like this https://github.com/Efimj/GameOfLife/blob/master/app/src/main/java/com/jobik/gameoflife/screens/settings/SettingsContent.kt

Of course you can try 🙃

Gukkey commented 2 months ago

Screen_recording_20240814_235448.webm

This should be good right?

Efimj commented 2 months ago

Screen_recording_20240814_235448.webm This should be good right?

It looks pretty good ❤, but the theme icon should be the opposite, hinting that the theme will change when clicked. I would also experiment with the design, maybe add a description of the selected theme, or perhaps include a label on the right. These are just the first ideas that came to mind; be creative!

Gukkey commented 2 months ago

but the theme icon should be the opposite, hinting that the theme will change when clicked

You mean the icon should hinting the next theme? If yes, I think it will confuse the users.

I have added the labels.

Screen_recording_20240815_005258.webm

Efimj commented 2 months ago

You mean the icon should hinting the next theme? If yes, I think it will confuse the users.

I've seen various UI examples, and I like how yours turned out. Keep it as is)

Gukkey commented 2 months ago

I will make a PR now, the translations for "System" might not be accurate since I used Google Translate but I will change them if someone finds a mistake in those in the future.