search

Eggeling-Lab-Microscope-Software / TRAIT2D

TRAIT2D is a cross-platform Python software package with compilable graphical user interfaces (GUIs) to support Single Particle Tracking experiments.
GNU General Public License v3.0
10 stars 10 forks source link

New MSD & Rename #66

Closed Zatyrus closed 2 years ago

Zatyrus commented 2 years ago

Added the new MSD calculation including garbage collection in trait2d/analysis/__init__.py.

Also renamed Diffusion.display_trajectory to Diffusion.plot_trajectory for easier naming convention. For this please see that the analysis scripty already use the name 'plot_trajectory'.

john-wigg commented 2 years ago

Hey, I just saw you already closed this.

Just in case you were wondering why the tests are failing, I think this is because you're not assigning values to self._msd_error.

Also, apparently, the results of the new MSD calculation do not seem to closely match the ones of the old calculation. It would probably be a good idea to compare the results of both variants manually. If the new method looks good enough I can just update the tests.

Zatyrus commented 2 years ago

Yeah, I saw too late that I totally forgot about the msd_error. Will add it tomorrow.