deth_ctf - computeAddress() precompute the address wrongly

[Kaiziron]

Description

computeAddress() precompute the vault address wrongly, the constructor is taking the owner address as an argument, however it is using only the creation code of vault when precomputing the address, resulting in a wrong address.

Impact

The precomputed address will be wrong

Solution

Include the constructor argument msg.sender when precomputing the address :

    function computeAddress() public view returns (address) {
        bytes32 salt = bytes32(uint256(uint160(msg.sender)));
        return address(uint160(uint256(keccak256(abi.encodePacked(
            bytes1(0xff),
            address(this),
            salt,
            keccak256(abi.encodePacked(type(Vault).creationCode, abi.encode(msg.sender)))
        )))));
    }

[0xdeth]

Very good, this was the original issue!.

Gj @Kaiziron.