search

Egoistically / ALAuto

Azur Lane bot based on azurlane-auto. Discord: https://discord.gg/vCFxDen.
Do What The F*ck You Want To Public License
106 stars 43 forks source link

All necessary stuff for JP server #58

Closed phantasmalmira closed 4 years ago

phantasmalmira commented 4 years ago

except some assets that I can't get my hands on myself.

hjk22 commented 4 years ago

First of all, thank you for sharing your assets. I reviewed them and excluding the ones related to the Crosswave event and later chapter maps (ch11-12 and event nodes), you have got all of them except for combat/menu_fleet.png: you can get this one from the fleet selection menu after you have chosen a story chapter. Also I noticed that for the headquarters module you are using bigger assets than the one we are using (academy_alert.png, dorm_alert.png and cat_lodge_alert.png) and I wanted to ask you if they were working fine because at the start I made them bigger too, but I had to resize them because of false positives (refer to issue #51 ). If there are problems, try employing the ones we are currently using since there shouldn't be differences between the servers in this case. Just add that missing asset and we are good to go. Also if you could squash your commits into a single one, that would be great.

phantasmalmira commented 4 years ago

sorry about the headquarters, I have certainly tried it with the EN assets at first, however, academy_alert wouldn't get picked up until .8 similarity, dorm_alert is .97 and cat_lodge is at .98. Since all of them are under the similarity requirements in the script, I took new assets, and yes, it's affected by issue #51. I got the same dimensions as the EN ones and it's fixed now, I will close this request and put one up after I squashed down all of it into one Thanks