VSIX ships a lot of unrelated files, including Roslyn

EgorBo / Disasmo

VS2022 Add-in. Click on any method or class to see what .NET Core's JIT generates for them (ASM).

MIT License

638 stars 39 forks source link

VSIX ships a lot of unrelated files, including Roslyn #22

Open Therzok opened 3 years ago

Therzok commented 3 years ago

It should just reference dlls and allow the roslyn host to load them. Right now, the extension (along with some others) cause my VS to not show quick info. :D

EgorBo commented 3 years ago

@Therzok ah yeah, something definitely went wrong here 🙂 Initially the addin was based on the LightBulb sample from https://github.com/microsoft/VSSDK-Extensibility-Samples/tree/master/LightBulb (it's pretty out of date)

trying to figure out how to optimize it.

EgorBo commented 3 years ago

hm.. looks like most of it comes with "Microsoft.CodeAnalysis.EditorFeatures.Text" nuget package which is only needed for GetRelatedDocuments() API

Therzok commented 3 years ago

You can most likely ship the vsix without bundling Roslyn, but by having a dependyencu on the .net sdk extension

Therzok commented 3 years ago

The assemblies exist in the appdomain, and the host will redirect you to the version it uses. Basically, all the imported packagereference that already exist in VS have to not be locally copied.