EgorBo / Disasmo

VS2022 Add-in. Click on any method or class to see what .NET Core's JIT generates for them (ASM).
MIT License
642 stars 39 forks source link

NullReferenceException in ObjectLayoutSuggestedAction.GetSymbol #5

Closed sharwell closed 5 years ago

sharwell commented 5 years ago

After reviewing data submitted by a user in Executing View.QuickActions often throws an exception, I found it's possible for a NullReferenceException to be thrown in ObjectLayoutSuggestedAction.GetSymbol, which eventually propagates to CommonSuggestedActionsSource.HasSuggestedActionsAsync. This unhandled exception causes the lightbulb to misbehave. The following screenshot shows the problematic call stack:

image

EgorBo commented 5 years ago

@sharwell wow, thanks!! will fix

sharwell commented 5 years ago

@EgorBo No problem. I was happy to find that the extension was open source so I could get the info to you 👍