search

EgorKulikov / idea-chelper

Automatically exported from code.google.com/p/idea-chelper
112 stars 59 forks source link

Initialize Gradle project #67

Open ntviet18 opened 6 years ago

ntviet18 commented 6 years ago

Hi @EgorKulikov ,

Do you consider applying Gradle structure to CHelper? Here I make a few quick changes that possibly make the development and deployment processes a little bit more convenient, e.g.

0) Run tests: ./gradlew test 1) Run sandbox: ./gradlew runIde 2) Package: ./gradlew buildPlugin 3) Publish: ./gradlew publishPlugin 4) etc.

Note: I didn't change anything in your code except some files were automatically migrated from CLRF to LF. I will revert them back if you think this pull request is likely to be merged.

scruel commented 6 years ago

I think Maven is totally enough for this project.

ntviet18 commented 6 years ago

@scruel , I agree that Maven is more popular. But it seems Jetbrains doesn't support Maven in plugin development https://www.jetbrains.org/intellij/sdk/docs/basics/getting_started.html

scruel commented 6 years ago

@ntviet18 It says "The recommended workflow", not unsupported.

jmerle commented 6 years ago

~I'd say Gradle is preferred considering Jetbrains~ nevermind, ntviet18 beat me to it.

Anyhow, +1 on this, except that it would be better to add the latest version of Gradle (4.9 instead of 4.7) in my opinion.

By the way, it seems like you somehow changed the line-endings in all the files.

ntviet18 commented 6 years ago

@scruel , It would be nice if you know some official supports from Jetbrains. I think this https://plugins.jetbrains.com/plugin/7127-intellij-plugin-development-with-maven should probably works, but I can't find any explanation documentation how to use it.

@jmerle , Thank you for you support. I tried Gradle 4.8, but it failed with some Ivy conflicts. Maybe 4.9 would work. I think we will try again after receiving some feedback from @EgorKulikov .

jmerle commented 6 years ago

@scruel I think the argument ntviet18 gave to counter the "Maven is enough" is actually quite valid. JetBrains recommends that you use Gradle for new projects, or Plugin DevKit for existing projects. At the moment, the latter is in use, although Gradle offers some advantages, like easier handling (in my opinion) of dependencies and running the IDE with the extension installed for local testing. In my eyes, those two features are worth switching from Plugin DevKit to Gradle.

I don't think it's a Gradle or Maven thing, I think it's a Gradle or Plugin DevKit thing.

EgorKulikov commented 6 years ago

Hi!

I think switching to gradle is a good idea. I would appreciate if you would resolve conflicts with beta branch (and please, make all future pull requests based on beta)

ntviet18 commented 6 years ago

@EgorKulikov , I updated the pull request. Please check.

EgorKulikov commented 6 years ago

I am omw to google code jam, so I’ll likely will process this next week

ntviet18 commented 6 years ago

@EgorKulikov , good luck!

scruel commented 5 years ago

@ntviet18 Sorry for unchecked words. I used to believe this project has already been managed by maven (in fact it's the IDEA auto-import), until I update IDEA to 2018.2, then the compile error occurs... For future plugin development and my own convenience, I will merge your PR into my forked project manually to fix it. Thanks!

ntviet18 commented 5 years ago

@scruel , cheer! I'm not sure what are you sorry about. But if you want to discuss it, please feel to comment.

sharoha commented 5 years ago

Were you able to complete the gradle integration with this project. I came up with a similar idea and found out about this pull request. It will be a nice addition to this plugin.