EgorMaksimov / mintty

Automatically exported from code.google.com/p/mintty
GNU General Public License v3.0
0 stars 0 forks source link

Newline wrongly included when selecting past the start of a line #144

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
During text selection, if the mouse is dragged to the left of the window,
the newline preceding the line the mouse is on is included in the selection.

The same issue occurs when starting a selection to the left edge of the
first character on a line, which is quite easy to do when the window is
maximised.

Original issue reported on code.google.com by andy.koppe on 2 Nov 2009 at 4:08

GoogleCodeExporter commented 8 years ago
Fixed in r635 on 0.5 branch, albeit at the cost of including the first 
character when
selecting downwards and dragging the mouse to the left of the window.

The underlying issue is that the mouse positioning ranges from 0 to 79 for an
80-column window, when it should really be 0 to 80 to distinguish "before the 
first"
and "after the last" character. Fixing that would require some redesign of all 
the
selection-related code, so leaving that for the moment.

Original comment by andy.koppe on 3 Nov 2009 at 8:36

GoogleCodeExporter commented 8 years ago
Improved fix in r636 on 0.5 branch, no longer including the first character on 
a line
when selecting downwards and dragging the mouse to the left of the window.

Original comment by andy.koppe on 4 Nov 2009 at 9:22

GoogleCodeExporter commented 8 years ago

Original comment by andy.koppe on 4 Nov 2009 at 9:22

GoogleCodeExporter commented 8 years ago

Original comment by andy.koppe on 7 Nov 2009 at 6:57