search

Egyras / HeishaMon

Panasonic Aquarea air-water H, J, K and L series protocol decrypt
242 stars 122 forks source link

update WebSockets to 2.4.1 or later? #512

Closed mi-hol closed 2 months ago

mi-hol commented 2 months ago

platformio.ini currently uses

links2004/WebSockets@^2.4.0

but release 2.4.1 includes fixes like: "Avoid buffer overflow for small Basic Authentication header by @matth-x in https://github.com/Links2004/arduinoWebSockets/pull/841 Fix memory leak and improve performance by @BetterComputing in https://github.com/Links2004/arduinoWebSockets/pull/852"

Therefore I wonder if the dependency should be at least be updated to this version or even the latest 2.6.0 for newer hardware support?

geduxas commented 2 months ago

Main key word, MIGHT, and IN BASIC AUTH, which is not used in heishamon, yes it's better to use lastest lib's, but before it should run for testing. Heishamon is highly demand in resources, so everything could break it

IgorYbema commented 2 months ago

You did point me at something :-) We don't use the websockets library anymore. It has it own implementation (also due to memory requirements). But there is still some old code pointing to this so I need to remove that.

mi-hol commented 2 months ago

closed via https://github.com/Egyras/HeishaMon/commit/00e5d4d42123ae9e03009f48d078db126433e86a