search

Egyras / HeishaMon

Panasonic Aquarea air-water H, J, K and L series protocol decrypt
242 stars 122 forks source link

Remove unused dependencies #520

Closed mi-hol closed 2 months ago

mi-hol commented 2 months ago

With recent changes 2 dependencies became unused. I went ahead and removed them but have no possibility to test the created bin yet! Build action https://github.com/mi-hol/HeishaMon/actions/runs/10759232099 is successful

mi-hol commented 2 months ago

@IgorYbema looking at .github/workflows/main.yml the command line is now: run: arduino-cli lib install ringbuffer pubsubclient arduinojson dallastemperature onewire "Adafruit NeoPixel"

Therefore the open question is: Is platformio.ini actually used?

IgorYbema commented 2 months ago

No and I don't know how that got into the repo

geduxas commented 2 months ago

@IgorYbema looking at .github/workflows/main.yml the command line is now: run: arduino-cli lib install ringbuffer pubsubclient arduinojson dallastemperature onewire "Adafruit NeoPixel"

Therefore the open question is: Is platformio.ini actually used?

No platformIO is not used. #376 is all it's history.

mi-hol commented 2 months ago

thanks for clarification, I've amended PR accordingly