search

EhPanda-Team / EhPanda

An unofficial E-Hentai App for iOS built with SwiftUI & TCA.
https://ehpanda.app
MIT License
3.04k stars 204 forks source link

[BUG] failed image fetching retry feature not work #283

Closed StoneMoe closed 1 year ago

StoneMoe commented 1 year ago

Describe the bug when image didn't load, the "retry icon" button and the "Retry all failed images" option in dropdown menu will usually keep failing too. but "Reload all images" option will usually instantly success

To Reproduce Steps to reproduce the behavior:

  1. Browse images until it failed to load
  2. tap "retry icon", it will usually keep failing
  3. tap "Reload all images" will usually fix it

Expected behavior higher retry success rate.

Please complete the following information:

Additional context it seems "Reload all images" will fetching image from different h@h server. but "retry failed image" won't.

tatsuz0u commented 1 year ago

Thanks for your feedback.

Retry all failed images: Remove loading failed flags and try loading images with previous URLs again. Reload all images: Retrieve new URLs and try loading images with them again.

I think they both work but in a different way. Always try Retry all failed images first since it doesn't consume your gallery points unless it never works to you.

cc @chihchy Close this issue if not response from the issuer in 1d.