EhPanda-Team / EhPanda

An unofficial E-Hentai App for iOS built with SwiftUI & TCA.
https://ehpanda.app
MIT License
3k stars 204 forks source link

Fix most warnings #372

Closed Jimmy-Prime closed 1 month ago

Jimmy-Prime commented 2 months ago

This pr fix all but two warnings before migrating to TCA 1.0.

Most of the warnings are

The technique used here is turn methods in client to simple method or async method if it uses promise

For example:

Then make corresponding changes in reducers


The warnings left are

EhProfileRequest(action: .create, name: "EhPanda").effect.fireAndForget()

// and

extension Request {
    var effect: Effect<Result<Response, AppError>> {
        publisher.receive(on: DispatchQueue.main).catchToEffect()
    }
tatsuz0u commented 1 month ago

Thank you for your PR again! We really need some contributions these days. (haven't release a update for six months XD)