EhPanda-Team / EhPanda

An unofficial E-Hentai App for iOS built with SwiftUI & TCA.
https://ehpanda.app
MIT License
3k stars 204 forks source link

Jimmy/fix publisher deprecated #376

Closed Jimmy-Prime closed 1 month ago

Jimmy-Prime commented 1 month ago

In this pr:

I think the ideal fix is to change the model of Request from publisher to async function, because request should only be evaluated once, but this is not practical to do in one pr. I found a useful snippet from this artical, which transform a publisher to an async throwing function. I modified this snippet to non-throwing and use a typed error.


I found the nested binding was broken in my earlier pr. There is a suggested fix from version 0.55.0 to use Reducer.onChange

tatsuz0u commented 1 month ago

Thanks for your recent contributions to EhPanda! We're glad to have you here. 😄