EhabBug / dropdown-check-list

Automatically exported from code.google.com/p/dropdown-check-list
0 stars 0 forks source link

Only first of multiple selected options is selected in Chrome 12 #176

Open GoogleCodeExporter opened 8 years ago

GoogleCodeExporter commented 8 years ago
** What steps will reproduce the problem?
See demo page at: 
http://dropdown-check-list.googlecode.com/svn/trunk/doc/ddcl-tests.html in 
Chrome 12 (dev)

** What is the expected output? What do you see instead?

In section "First Item Checks All (not selected), all others preselected" -> 
"All items selected EXCEPT the first" all items should be selected.

What I see: Only first item ("Low") from the list of selected items is selected.

** What is your environment?
-- Browser and version: Chrome 12

** Please provide any additional information below

We debugged this in our application with an older version of 
dropdown-check-list and the problem seemed to be in the line 
-
sourceSelect.attr("multiple", true);
-
(Line 740 on trunk now)

The <select> item already had multiple set to true. When re-setting it to true 
seems that latest Chrome re-initializes the list and only selects the first one 
(maybe going through multiple=false so only selecting one first..).

We fixed this by wrapping the setting of the multiple attribute in an:
--
if(!self.isMultiple)
--
Everything seems to work with this addition.

Original issue reported on code.google.com by cristian...@gmail.com on 15 Apr 2011 at 10:12

GoogleCodeExporter commented 8 years ago
Sorry..condition for fix should have been more like:
--
if(!self.initialMultiple && self.isMultiple)
--

Original comment by cristian...@gmail.com on 15 Apr 2011 at 10:17

GoogleCodeExporter commented 8 years ago
My copy of Chrome is at version 10, which reports itself as the latest update.  
I see a beta 11 version available, and no mention of a version 12.
Since it is operating properly with version 10, and I do not intend to support 
unstable new versions of browsers (note, no testing with IE 9 yet either), I 
will regard this issue as out of scope.

If it appears with a stable, released version of Chrome 11, I will address it 
then. You may want to report this back to google chrome support, since it 
sounds more like a problem with the browser code.

Original comment by womohun...@ittrium.com on 16 Apr 2011 at 7:53

GoogleCodeExporter commented 8 years ago
True, chrome dev channel needn't be supported anywhere... and it might be a 
chrome bug. 

However, it does seem useless to force set multiple=true for elements which 
already have multiple=true, which is what causes the issue experienced on 
latest chrome dev channel...

Original comment by cristian...@gmail.com on 17 Apr 2011 at 6:10

GoogleCodeExporter commented 8 years ago
Chrome 12 is now in Beta and the multi-selected value still doesn't work.

Original comment by mille...@hotmail.com on 10 May 2011 at 9:10

GoogleCodeExporter commented 8 years ago
I had this issue too.  Cristian, thanks for the fix, it worked great.

Original comment by dfoxina...@gmail.com on 14 May 2011 at 9:25

GoogleCodeExporter commented 8 years ago
Again - I would encourage anyone who encounters this problem to report it back 
to the Chrome Beta team.  Since it is not an issue with any other browser and 
not an issue with earlier versions of Chrome, they will probably want to treat 
it like a bug.

Original comment by womohun...@ittrium.com on 16 May 2011 at 2:55

GoogleCodeExporter commented 8 years ago
I have raised a bug report on Chrome
http://code.google.com/p/chromium/issues/detail?id=80672

But I doubt they will change/fix anything as the javascript code can be amended 
to work.

Original comment by mille...@hotmail.com on 16 May 2011 at 6:51

GoogleCodeExporter commented 8 years ago
This appears to be working with the latest Dev build of Chrome 13.0.772.0 dev-m

Original comment by mille...@hotmail.com on 24 May 2011 at 7:34

GoogleCodeExporter commented 8 years ago
Hi Dfoxina,

How you got this fix, i am facing same problem, my chrome browser version is 
12.0742.

In, all other broswers my multiple select option show checked value for 
Checkbox.

But its not working same for Chrome, may i know the proper fix?

Its urgent,reply would be appreciated.

Thanks

Original comment by vinit2...@gmail.com on 9 Jun 2011 at 4:09

GoogleCodeExporter commented 8 years ago
vinit2: I simply edited the source code according to the fix that Christian 
provided in the first two posts.

Original comment by dfoxina...@gmail.com on 12 Jun 2011 at 6:48

GoogleCodeExporter commented 8 years ago
Just a note..

It turned out to be a WebKit bug/regression. It was already fixed in WebKit and 
the fix will carry-over to Chrome when they move to newer WebKit version. 

It's fixed already in Chrome 13 where they moved to newer version but 
apparently it didn't get into Chrome 12.

So after Chrome 13 is released this could be completely closed..

Original comment by cristian...@gmail.com on 12 Jun 2011 at 3:01

GoogleCodeExporter commented 8 years ago
Issue 189 has been merged into this issue.

Original comment by womohun...@ittrium.com on 14 Jun 2011 at 7:09

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Go ahead and delete comments. 

Add this to the code: if(!self.initialMultiple && self.isMultiple)

thanks.

Original comment by mlave...@gmail.com on 24 Jun 2011 at 6:17

GoogleCodeExporter commented 8 years ago
Thanks christian -- your fix worked really well

Original comment by mlave...@gmail.com on 24 Jun 2011 at 6:32

GoogleCodeExporter commented 8 years ago
Thanks christian
your help means a lot for me

Original comment by ardi4...@gmail.com on 27 Jun 2011 at 10:04

GoogleCodeExporter commented 8 years ago
Thanks soo much Christian! I was racking my head for a while thinking I was 
using it wrong or Chrome didn't support it, until I tried it in IE and it 
worked so I knew there was a bug in the jquery or chrome.

New ui.dropdownchecklist-1.4-ming.js file:
http://pastebin.com/Xt6eFF8A

Original comment by buddyfav...@gmail.com on 30 Jun 2011 at 5:34

Attachments:

GoogleCodeExporter commented 8 years ago
Where do I put this code "if(!self.initialMultiple && self.isMultiple)"
in ui.dropdownchecklist-1.4-min.js
or in my code
$("#item").dropdownchecklist( XX );

Please help, thanks anyone for a little more detail solution.

Original comment by jur...@gmail.com on 2 Jul 2011 at 9:30

GoogleCodeExporter commented 8 years ago
Issue 193 has been merged into this issue.

Original comment by womohun...@ittrium.com on 5 Jul 2011 at 2:20

GoogleCodeExporter commented 8 years ago
Issue 199 has been merged into this issue.

Original comment by womohun...@ittrium.com on 26 Jul 2011 at 3:26

GoogleCodeExporter commented 8 years ago
Issue 200 has been merged into this issue.

Original comment by womohun...@ittrium.com on 28 Jul 2011 at 2:33

GoogleCodeExporter commented 8 years ago
I'm sorry.. I am having the very same problem. First, I am not sure what file 
Christian is talking about editing but it seems to be 
ui.dropdownchecklist-1.4-min.js.. If so, there isn't any code resembling 
"sourceSelect.attr("multiple", true);" which he mentioned in the first post.. 
Second, I tried to implement "buddyfav...@gmail.com"'s file and it did not 
solve the problem for my Chrome browser... and not to open a whole other bag of 
worms.. but this does not not work in my explorer browser as well.. Would love 
to get this problem solved on my end.. Thanks everyone. > . <

Original comment by EmailTyr...@gmail.com on 29 Jul 2011 at 3:05

GoogleCodeExporter commented 8 years ago
Second this. 
The latest version does indeed have this bug in chrome 12 as well as IE9.

Original comment by talktop...@gmail.com on 31 Jul 2011 at 5:48

GoogleCodeExporter commented 8 years ago
[deleted comment]
GoogleCodeExporter commented 8 years ago
Is there any chance that this problem will be fixed in the near future?

Original comment by musicmak...@gmail.com on 3 Aug 2011 at 3:21

GoogleCodeExporter commented 8 years ago
The temporary fix has been documented in comment 1 and an updated js file that 
includes the temporary fix was posted in comment 19.  If you need a fix before 
Chrome 13 is released, please reference the above.

Original comment by womohun...@ittrium.com on 3 Aug 2011 at 3:32

GoogleCodeExporter commented 8 years ago
Chrome 13 released 03August2011
My tests with Chrome 13 shows no trace of this problem.

Many thanks to Cristian for the analysis and fix, and to Buddyfav for posting 
the patched js file.

??? This problem was also reported for IE9 - but I am not seeing it from my 
test environment.  Does anyone else out there have this problem with IE9???

Original comment by womohun...@ittrium.com on 3 Aug 2011 at 8:28

GoogleCodeExporter commented 8 years ago
Issue 203 has been merged into this issue.

Original comment by womohun...@ittrium.com on 6 Aug 2011 at 5:05

GoogleCodeExporter commented 8 years ago
I have just had a report that this problem is still active for someone using 
Chrome 13. I cannot reproduce it -- for my environments, Chrome 13 (and IE 9, 
for that matter) operate as expected.

So I need some help from the community out there: is anyone else out there 
still seeing this problem with either Chrome 13 (13.0.782.107) or IE 9 ????

Original comment by womohun...@ittrium.com on 6 Aug 2011 at 5:09

GoogleCodeExporter commented 8 years ago
Just re-checked using the demo page and also my minimal test-case for the 
webkit bug and both Chrome 13 and IE9 seem to be working without any problems.

Since the cause for all of this was a regression in webkit, it doesn't make 
sense to be happening in IE9. Maybe there is some IE9-specific issue but since 
nobody gave a nice and simple reproduction it might be related to other code 
running in the specific site.

Original comment by cristian...@gmail.com on 6 Aug 2011 at 7:25