search

EhrmannS / geometr

Generate and modify interoperable geometric shapes
https://ehrmanns.github.io/geometr/
14 stars 1 forks source link

CRAN testthat failures #7

Open rsbivand opened 1 year ago

rsbivand commented 1 year ago

With current sp and raster, testthat fails. testthat.Rout.zip 00check.log

Untried: maybe the strings need to be sp::CRS objects. However, given: https://r-spatial.org/r/2022/04/12/evolution.html you should migrate to terra and/or sf/stars ASAP. raster already uses terra under the hood.

EhrmannS commented 1 year ago

Dear Roger,

thanks for the note and yeah, I think you might be right about the sp::CRS-objects. Will look into this next week, or is there any tighter deadline attached to this somewhere?

About migrating, the idea of those getters and setters is that they work on any spatial class. So as long as raster is available, I would like to support also working with raster objects, for the sake of backwards compatibility.