EiadurRahman / semiautomated_plant_care

A science fair project
0 stars 1 forks source link

thingesp module import #3

Closed cheattheweb closed 7 months ago

cheattheweb commented 7 months ago

Code organization

the send_msg() function is defined outside the Client class, why? if it is closely related to the functionality of the Client Class, consider moving it inside the class

cheattheweb commented 7 months ago

you have also imported usocket, ustruct and os Why? remove them if not needed

EiadurRahman commented 7 months ago

Code organization

the send_msg() function is defined outside the Client class, why? if it is closely related to the functionality of the Client Class, consider moving it inside the class

did all the necessary changes you suggested

cheattheweb commented 7 months ago

add some comments, about the pins, d1, d2 What they do? something like that, Or Pin name

cheattheweb commented 7 months ago

Where is the send_msg() now?