Added http client implementation based on Eiffel Net (i.e socket)

EiffelWebFramework / EWF

Eiffel Web Framework -- Provide a common framework to build easily web server application in Eiffel (portable on various connector and platforms)

http://eiffelweb.projects.eiffel.org/

Other

44 stars 26 forks source link

Added http client implementation based on Eiffel Net (i.e socket) #168

Closed jocelyn closed 8 years ago

jocelyn commented 9 years ago

I forgot to mention, but the code is the result of student project from Florian Jacky. And I updated/fixed/improved part of the code. But there are still work to do. For instance try to support persistent connection, support multiple upload files, and so on. The libcurl implementation added constraints, but I guess we can remove them, and eventually report "not supported" feature .. when libcurl is used. And/Or reverse.

I guess , for now, there is no support for proxy in net implementation. It will come if we, or a user has the need. Either by contribution by any user, or update from EWF team.

Regards, and thanks for any comment, feedback, code.

jocelyn commented 9 years ago

Additional information: this pull request is mostly to get feedback and code review. this is not YET intended to be merged into main EWF.

There are still a few issues, maybe related to the use of ready_for_reading , or various timeout. investigation is in progress. As a real test, we are trying to make it work with firebase rest api. (see EWF/redwood project)

Regards.

colin-adams commented 9 years ago

How/where do I see EWF/redwood project?

jocelyn commented 9 years ago

This is an experimental library to access firebase REST api, mostly contributed by Javier Velilla. And this is good, since current "net" http_client has trouble with it, while the "libcurl" http_client seems to work fine. So this is good opportunity to reproduce issue and hopefully fix them.

redwood, or the Eiffel firebase api : https://github.com/EiffelWebFramework/Redwood

jocelyn commented 9 years ago

Thanks to Javier, we fixed the timeout issue. And in the meantime, I also fixed a few protocol issues, and header related issue.

Now, next step if more tests, and obviously have smaller routine. As TODO, we may have

implement proxy support (would be helpful with fiddler2 for instance)
implement better MIME encoding, for now the "boundary" is always the same .. which is not good.
and a few others points that I may have forgetten for now.

BUT the good news is the Eiffel firebase library (named redwood), is working with the "net" http client.

thanks again Javier, that pointed me to what was under my nose, and helped fixing that code (I was blind for a time ;) )

jocelyn commented 8 years ago

It was integrated long time ago, closing this pending PR.