Eigenbahn / ai-dungeon-cli

:european_castle: A cli client to play.aidungeon.io
MIT License
150 stars 34 forks source link

readline broke OSX build #10

Closed Zer0xFF closed 4 years ago

Zer0xFF commented 4 years ago

so there are 2 issues as of the readline merge. 1) readline.get_line_buffer is a function so its missing () operator 2) adding the operator, you notice that process_next_action() is now continusly looping without user input, since readline.get_line_buffer() seems to be a none blocking call.

Traceback (most recent call last):
  File "ai_dungeon_cli/__init__.py", line 353, in <module>
    main()
  File "ai_dungeon_cli/__init__.py", line 337, in main
    ai_dungeon.start_game()
  File "ai_dungeon_cli/__init__.py", line 303, in start_game
    self.process_next_action()
  File "ai_dungeon_cli/__init__.py", line 294, in process_next_action
    if user_input.startswith("/remember"):
AttributeError: 'builtin_function_or_method' object has no attribute 'startswith'
otreblan commented 4 years ago

11 should fix this

p3r7 commented 4 years ago

Thanks!

I merged on a phone wo/ the ability to test.

I really need to implement automated tests.

otreblan commented 4 years ago

It works ok now Peek 27-02-2020 14-17

Zer0xFF commented 4 years ago

cool, this can be closed so