Closed Zer0xFF closed 4 years ago
my editor tells me id is a reserved keyword and should not be used a variable name
I can't find anything about that online or python doc, but i can make the change
we cannot call r.raise_for_status() if we call directly .json() on the requests response object
👍
I'm not super fan of printing every session_id line by line without any context
oops, that was there for debug only, i don't think we should return valid ids in that call, if thats needed it should be its own function*, while leads me to the next point, if we're not printing the ids, we dont need that part of the code and we can just id validity through story_session
* rough estimate, I have 50+ session, returning them is essentially spam
Yes indeed, if the backends can store that many sessions we should not display them.
I'll do a bit of testing and will come back to you.
Hey!
Thanks for the feature.
A few remarks:
id
is a reserved keyword and should not be used a variable namer.raise_for_status()
if we call directly.json()
on the requests response objectI propose something like the following instead (untested):