search

Eigenstate / vmd-python

Installable VMD as a python module
Other
129 stars 24 forks source link

Silencing dcd reader a bit #18

Closed RasmusFonseca closed 5 years ago

Eigenstate commented 5 years ago

Can you do this without adding another conditional compilation flag? You can just straight up delete the printf statments, that's fine (and what I did for netcdfplugin).

There's no point in being able to turn these print statements on and off at compile time, and I'll just end up passing -DDCD_VERBOSE to everything along with the million other compile time defines VMD wants. This is also a really specific flag-- if there were a general one for MOLFILEPLUGIN_VERBOSE you could maybe have a case for it.

See: https://www.cqse.eu/en/blog/living-in-the-ifdef-hell/

RasmusFonseca commented 5 years ago

The default behavior is to omit the print if you don't pass any argument (so it's more like they're commented out). Happy to delete instead, though.