Actually compile a dynamic PIC library

Eigenstate / vmd-python

Installable VMD as a python module

Other

132 stars 25 forks source link

Actually compile a dynamic PIC library #23

Closed jvermaas closed 5 years ago

jvermaas commented 5 years ago

I think this will fix Austin's issue with python refusing to load a non-dynamic library (https://github.com/Eigenstate/vmd-python/issues/22#issuecomment-468037883). For whatever reason, VMD's configure didn't have the PIC compiler options for a shared library, probably because nobody tried to do this before.

austinpagan commented 5 years ago

So, I should just do a regular git clone --branch ppc64le https://github.com/Eigenstate/vmd-python and I will get this new proposed fix?

jvermaas commented 5 years ago

Honestly, I'm not sure. I can't commit directly to Robin's version. Until she accepts the pull request, the usual "git pull" won't work unless you rebase or temporarily clone my fork... Oh wait. Github has instructions for this situation. https://help.github.com/en/articles/checking-out-pull-requests-locally