Add waitfor back to molecule.write

Eigenstate / vmd-python

Installable VMD as a python module

Other

129 stars 24 forks source link

Add waitfor back to molecule.write #34

Closed jvermaas closed 3 years ago

jvermaas commented 3 years ago

As it stands right now, calling Molecule.write fails, because the underlying molecule.write call doesn't match the spec, since somewhere along the way the underlying molecule.write lost the waitfor parameter. This adds it back, but does not change the default behavior (write everything before returning).

jvermaas commented 3 years ago

sigh apparently this pull was too quick. The stuff in Molecule.py is still complaining. In this case a type check won't let an atomsel object be none, which is what Molecule.save was doing.

jvermaas commented 3 years ago

Now its fixed.

Eigenstate commented 3 years ago

LGTM. Sorry this took me so long to merge.