search

Eight-Mansions / linda-cubed-again

65 stars 1 forks source link

Possible stack corruption in SetBabyLetWidth #3

Closed Goatman13 closed 7 months ago

Goatman13 commented 7 months ago

It seems that function accidentally corrupts single word here:

https://github.com/Eight-Mansions/linda-cubed-again/blob/74c79008e668edf1b8dbf528415550f8ee34c1d2/code/linda_vwf.asm#L12

    addiu sp, sp, -8
    sw a0, 4(sp)
    jal SetLetter   
    sw a1, 8(sp) <---

Keep in mind that I'm just looking at patch code, without checking game code yet. So, if that's intended then issue can be closed.

esperknight commented 7 months ago

Good catch! Yeah.... that's a not right haha. I guess that means A1 isn't used at least :D

esperknight commented 7 months ago

Fixed with latest patch :)