chore: usegestures: test for touch start positions in onmousemove

EightfoldAI / octuple

The Octuple component library

MIT License

16 stars 45 forks source link

chore: usegestures: test for touch start positions in onmousemove #753

Closed dkilgore-eightfold closed 7 months ago

dkilgore-eightfold commented 7 months ago

SUMMARY:

Test for touch start positions before setting gesture to null on mouse move.

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

ENG-70944

CHANGE TYPE:

[x] Bugfix Pull Request
[] Feature Pull Request

TEST COVERAGE:

[x] Tests for this change already exist
[x] I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Popup and Tooltip stories behave as expected.

codesandbox-ci[bot] commented 7 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3c40f0f2b670ebf23c969c23bd65aa2588df05b9:

Sandbox	Source
React	Configuration
JavaScript	Configuration

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1a9ebb3) 85.06% compared to head (3c40f0f) 85.06%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #753 +/- ## ======================================= Coverage 85.06% 85.06% ======================================= Files 887 887 Lines 18822 18823 +1 Branches 6936 6937 +1 ======================================= + Hits 16010 16012 +2 + Misses 2730 2729 -1 Partials 82 82 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.