Closed dkilgore-eightfold closed 10 months ago
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit f704f6992942a75279c3c413744574f73fb59259:
Sandbox | Source |
---|---|
React | Configuration |
Attention: 17 lines
in your changes are missing coverage. Please review.
Comparison is base (
87a570e
) 85.06% compared to head (f704f69
) 85.06%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
SUMMARY:
This PR contains the following updates to the
SkillTag
andSkillBlock
components:SkillBlock
andSkillTag
to consume them via a tuple mapping toSkillSize
andSkillAssessment
showLabelAssessmentIcon
prop toSkillBlock
andSkillTag
providing a way to hide the assessment icons if desiredSkillAssessment
including properties (Below
,Exceed
,Meet
,Upskilling
, ...)blockEndClassNames
,blockEndStyles
,blockStartClassNames
,blockStartStyles
toSkillBlock
andSkillTag
required
andrequiredMark
props toSkillBlock
andSkillTag
, along with the specified mark styles provided by UXinlineSvgProps
to support custom SVGs inSkillBlock
andSkillTag
suffixIconProps
andsuffixInlineSvgProps
to support custom suffix iconography in andSkillTag
(e.g. trending icon)default
,highlight
andmatch
SkillBlock
andSkillTag
and updates the components to use themfullWidth
prop toSkillTag
enabling a uniform size for vertical list implementationsbordered
prop to SkillTag such that its borders may be shown or hiddenmatchingSkillStatus
andmatchingSkillAssessment
helper properties to aid in mapping of Skillshttps://github.com/EightfoldAI/octuple/assets/99700808/f804bf84-33c1-46dd-a477-055a4e19f68f
JIRA TASK (Eightfold Employees Only):
ENG-69065
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
andyarn storybook
. Verify theSkillBlock
andSkillTag
stories behave as expected.