EightfoldAI / octuple

The Octuple component library
MIT License
17 stars 51 forks source link

feat: skill: adds svg and suffix support with assessments status and required props #758

Closed dkilgore-eightfold closed 10 months ago

dkilgore-eightfold commented 10 months ago

SUMMARY:

This PR contains the following updates to the SkillTag and SkillBlock components:

https://github.com/EightfoldAI/octuple/assets/99700808/f804bf84-33c1-46dd-a477-055a4e19f68f

JIRA TASK (Eightfold Employees Only):

ENG-69065

CHANGE TYPE:

TEST COVERAGE:

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the SkillBlock and SkillTag stories behave as expected.

codesandbox-ci[bot] commented 10 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f704f6992942a75279c3c413744574f73fb59259:

Sandbox Source
React Configuration
codecov[bot] commented 10 months ago

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (87a570e) 85.06% compared to head (f704f69) 85.06%.

Files Patch % Lines
src/components/Skill/SkillTag.tsx 86.30% 9 Missing and 1 partial :warning:
src/components/Skill/SVG/BelowLargeImg.tsx 50.00% 1 Missing :warning:
...c/components/Skill/SVG/BelowUpskillingLargeImg.tsx 50.00% 1 Missing :warning:
src/components/Skill/SVG/ExceedLargeImg.tsx 50.00% 1 Missing :warning:
.../components/Skill/SVG/ExceedUpskillingLargeImg.tsx 50.00% 1 Missing :warning:
src/components/Skill/SVG/MeetLargeImg.tsx 50.00% 1 Missing :warning:
...rc/components/Skill/SVG/MeetUpskillingLargeImg.tsx 50.00% 1 Missing :warning:
src/components/Skill/SVG/UpskillingLargeImg.tsx 50.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #758 +/- ## ========================================== - Coverage 85.06% 85.06% -0.01% ========================================== Files 887 908 +21 Lines 18821 18917 +96 Branches 6935 6983 +48 ========================================== + Hits 16011 16091 +80 - Misses 2728 2744 +16 Partials 82 82 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.