EightfoldAI / octuple

The Octuple component library
MIT License
16 stars 45 forks source link

feat: icon: add domain, circle slices and arrow head icons #761

Closed agupta-eightfold closed 6 months ago

agupta-eightfold commented 6 months ago

SUMMARY:

Adding the following icons as needed in the new Market Insights page/feature. Added storybook screenshots and design icons screenshots.

  1. Circle slices

    Screenshot 2023-12-14 at 5 46 41 PM Screenshot 2023-12-14 at 6 09 03 PM
  2. Arrow head directions

    Screenshot 2023-12-14 at 5 46 21 PM Screenshot 2023-12-14 at 6 08 54 PM
  3. Domain (from mdi.js)

    Screenshot 2023-12-14 at 5 46 51 PM Screenshot 2023-12-14 at 6 09 18 PM

GITHUB ISSUE (Open Source Contributors)

JIRA TASK (Eightfold Employees Only):

https://eightfoldai.atlassian.net/browse/ENG-73558

CHANGE TYPE:

TEST COVERAGE:

TEST PLAN:

Pull the PR branch and run yarn, and yarn storybook. Verify that the icons list and icons as per the screenshots provided in the summary.

codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c93fa43bcbeee75e309952a953141cdc6788a091:

Sandbox Source
React Configuration
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (740e172) 85.17% compared to head (c93fa43) 85.17%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #761 +/- ## ======================================= Coverage 85.17% 85.17% ======================================= Files 908 908 Lines 19113 19113 Branches 7075 7075 ======================================= Hits 16279 16279 Misses 2752 2752 Partials 82 82 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

agupta-eightfold commented 6 months ago

needs_ci

jhoward-eightfold commented 6 months ago

you can squash and merge, sonar cube doesn't really work right now do to funding issues (i think)