Closed dkilgore-eightfold closed 5 months ago
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 1a77bf66362db7d67e9e053175d425756811d614:
Sandbox | Source |
---|---|
React | Configuration |
Attention: 156 lines
in your changes are missing coverage. Please review.
Comparison is base (
501ddce
) 85.03% compared to head (1a77bf6
) 84.86%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
SUMMARY:
window
ordocument
where they are referenced, as well as validatingwindow
when request animation frame or cancel animation frame methods are used.https://github.com/EightfoldAI/octuple/assets/99700808/29977885-2993-44bf-bb3b-1081a76006f9
JIRA TASK (Eightfold Employees Only):
ENG-54729
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
andyarn storybook
. Verify the Grid stories behave as expected.