EightfoldAI / octuple

The Octuple component library
MIT License
16 stars 45 forks source link

feat: grid: adds xl breakpoint #762

Closed dkilgore-eightfold closed 5 months ago

dkilgore-eightfold commented 6 months ago

SUMMARY:

https://github.com/EightfoldAI/octuple/assets/99700808/29977885-2993-44bf-bb3b-1081a76006f9

JIRA TASK (Eightfold Employees Only):

ENG-54729

CHANGE TYPE:

TEST COVERAGE:

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Grid stories behave as expected.

codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1a77bf66362db7d67e9e053175d425756811d614:

Sandbox Source
React Configuration
codecov[bot] commented 6 months ago

Codecov Report

Attention: 156 lines in your changes are missing coverage. Please review.

Comparison is base (501ddce) 85.03% compared to head (1a77bf6) 84.86%.

Files Patch % Lines
src/components/Upload/Cropper/Cropper.tsx 0.00% 51 Missing :warning:
src/shared/utilities/css.ts 40.00% 21 Missing :warning:
src/components/Carousel/Carousel.tsx 0.00% 16 Missing :warning:
.../DateTimePicker/Internal/Tests/util/commonUtil.tsx 68.75% 10 Missing :warning:
src/hooks/useFontSize.ts 0.00% 7 Missing :warning:
src/components/Dialog/DialogHelper.tsx 0.00% 5 Missing :warning:
...omponents/ConfigProvider/Theming/styleGenerator.ts 81.81% 4 Missing :warning:
src/components/Skill/SkillBlock.tsx 55.55% 4 Missing :warning:
...omponents/Table/Hooks/useFilter/FilterDropdown.tsx 42.85% 4 Missing :warning:
src/components/Trigger/Trigger.tsx 73.33% 4 Missing :warning:
... and 17 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #762 +/- ## ========================================== - Coverage 85.03% 84.86% -0.18% ========================================== Files 999 999 Lines 19255 19407 +152 Branches 7112 7221 +109 ========================================== + Hits 16374 16469 +95 - Misses 2799 2856 +57 Partials 82 82 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.