EightfoldAI / octuple

The Octuple component library
MIT License
16 stars 45 forks source link

fix: table: showscroller rtl support #764

Closed dkilgore-eightfold closed 6 months ago

dkilgore-eightfold commented 6 months ago

SUMMARY:

https://github.com/EightfoldAI/octuple/assets/99700808/44c1faad-8eab-413f-90f4-5c67891d05b1

JIRA TASK (Eightfold Employees Only):

ENG-69421

CHANGE TYPE:

TEST COVERAGE:

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Table showScroller stories behave as expected in both canvas directions as demonstrated in the video.

codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a291c364d3097faca322b5abd03554ca8993c480:

Sandbox Source
React Configuration
codecov[bot] commented 6 months ago

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (e1c6207) 85.24% compared to head (a291c36) 85.05%.

Files Patch % Lines
src/components/Table/Internal/Body/Scroller.tsx 0.00% 69 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #764 +/- ## ========================================== - Coverage 85.24% 85.05% -0.19% ========================================== Files 999 999 Lines 19211 19255 +44 Branches 7075 7112 +37 ========================================== + Hits 16376 16377 +1 - Misses 2753 2796 +43 Partials 82 82 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.