fix: tooltip: dedupes tooltip id and updates story for screen readers

EightfoldAI / octuple

The Octuple component library

MIT License

17 stars 51 forks source link

fix: tooltip: dedupes tooltip id and updates story for screen readers #768

Closed dkilgore-eightfold closed 8 months ago

dkilgore-eightfold commented 9 months ago

SUMMARY:

Dedupes tooltipId
Adds tooltipWrapperID
Updates story to work with screen readers via tabIndex and aria-describedby changes

https://github.com/EightfoldAI/octuple/assets/99700808/84ab67d6-98f3-44b5-9ccc-a4e9744a11cf

GITHUB ISSUE (Open Source Contributors)

https://github.com/EightfoldAI/octuple/issues/763

JIRA TASK (Eightfold Employees Only):

ENG-74737

CHANGE TYPE:

[x] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:

[x] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Tooltip story works as expected using VoiceOver.

codesandbox-ci[bot] commented 9 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4c09478efb23a15f3fd3f97cb6faf5b4e1f6d292:

Sandbox	Source
React	Configuration

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (5772b80) 84.85% compared to head (4c09478) 84.85%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #768 +/- ## ======================================= Coverage 84.85% 84.85% ======================================= Files 999 999 Lines 19410 19411 +1 Branches 7224 7224 ======================================= + Hits 16471 16472 +1 Misses 2857 2857 Partials 82 82 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.