fix: slider: ensure touchmove is not prevented to enable default touch on mobile

dkilgore-eightfold commented 6 months ago

SUMMARY:

Provides a argument (preventTouchMoveDefault) to determine if touchmove should be handled in useGesture
Applies fix to Slider so the thumb may be dragged on mobile again

JIRA TASK (Eightfold Employees Only):

ENG-75094

CHANGE TYPE:

[x] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:

[x] Tests for this change already exist
[ ] I have added unittests for this change

Pull the PR branch and run yarn and yarn storybook. Verify the Slider stories behave as expected on touch screen by dragging the thumb.

TEST PLAN:

codesandbox-ci[bot] commented 6 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 62fe81aa4990cabaf13123e4baf2cd999ef1df9e:

Sandbox	Source
React	Configuration

codecov[bot] commented 6 months ago

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (501ddce) 85.03% compared to head (e415736) 85.05%. Report is 1 commits behind head on main.

:exclamation: Current head e415736 differs from pull request most recent head 62fe81a. Consider uploading reports for the commit 62fe81a to get more accurate results

Files	Patch %	Lines
src/hooks/useGestures.ts	33.33%	2 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #769 +/- ## ========================================== + Coverage 85.03% 85.05% +0.01% ========================================== Files 999 999 Lines 19255 19258 +3 Branches 7112 7115 +3 ========================================== + Hits 16374 16379 +5 + Misses 2799 2797 -2 Partials 82 82 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

EightfoldAI / octuple