fix: input: updates validation status font color to latest specification

EightfoldAI / octuple

The Octuple component library

MIT License

17 stars 51 forks source link

fix: input: updates validation status font color to latest specification #771

Closed dkilgore-eightfold closed 8 months ago

dkilgore-eightfold commented 8 months ago

SUMMARY:

Updates the default text validation status input font colors to --text-primary-color so they are consistent with invalidated state, deferring visual cue to its border and inline validation text

validationFontColorCorrected

JIRA TASK (Eightfold Employees Only):

ENG-65381

CHANGE TYPE:

[x] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:

[x] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Form stories behave as expected.

codesandbox-ci[bot] commented 8 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9354c2250292c7b327c7e0ca26cbec7198bdb521:

Sandbox	Source
React	Configuration

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (268b54f) 84.86% compared to head (9354c22) 84.85%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #771 +/- ## ========================================== - Coverage 84.86% 84.85% -0.01% ========================================== Files 999 999 Lines 19411 19411 Branches 7224 7224 ========================================== - Hits 16473 16472 -1 - Misses 2856 2857 +1 Partials 82 82 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.