fix: table: adds indeterminate state to check all box if only some rows are selected

EightfoldAI / octuple

The Octuple component library

MIT License

17 stars 51 forks source link

fix: table: adds indeterminate state to check all box if only some rows are selected #772

Closed dkilgore-eightfold closed 8 months ago

dkilgore-eightfold commented 8 months ago

SUMMARY:

Adds missing indeterminate state to check all CheckBox when only some rows are checked

https://github.com/EightfoldAI/octuple/assets/99700808/e0031889-6999-4fbd-8972-b0cda7b45843

JIRA TASK (Eightfold Employees Only):

ENG-75615

CHANGE TYPE:

[x] Bugfix Pull Request
[ ] Feature Pull Request

TEST COVERAGE:

[x] Tests for this change already exist
[ ] I have added unittests for this change

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Table stories behave as expected.

codesandbox-ci[bot] commented 8 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 506436467ed813bfa95a352cb22a1ee690424b45:

Sandbox	Source
React	Configuration

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c1a942c) 84.86% compared to head (5064364) 84.85%.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #772 +/- ## ========================================== - Coverage 84.86% 84.85% -0.01% ========================================== Files 999 999 Lines 19411 19418 +7 Branches 7224 7228 +4 ========================================== + Hits 16473 16477 +4 - Misses 2856 2859 +3 Partials 82 82 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.