EightfoldAI / octuple

The Octuple component library
MIT License
16 stars 45 forks source link

feat: carousel: adds size overlaycontrols and button props #774

Closed dkilgore-eightfold closed 5 months ago

dkilgore-eightfold commented 5 months ago

SUMMARY:

https://github.com/EightfoldAI/octuple/assets/99700808/b334a8ef-a672-4ada-8bab-9ec91f1cbe67

JIRA TASK (Eightfold Employees Only):

ENG-75830

CHANGE TYPE:

TEST COVERAGE:

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Carousel stories behave as expected.

codesandbox-ci[bot] commented 5 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2f2e524c5cc8797de771aa6ba234e06cc931520c:

Sandbox Source
React Configuration
codecov[bot] commented 5 months ago

Codecov Report

Attention: 69 lines in your changes are missing coverage. Please review.

Comparison is base (e0b8f12) 84.86% compared to head (2f2e524) 84.87%.

Files Patch % Lines
src/components/Carousel/Carousel.tsx 39.47% 69 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #774 +/- ## ======================================= Coverage 84.86% 84.87% ======================================= Files 999 999 Lines 19418 19496 +78 Branches 7228 7258 +30 ======================================= + Hits 16479 16547 +68 - Misses 2857 2869 +12 + Partials 82 80 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.