Closed dkilgore-eightfold closed 5 months ago
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit 2f2e524c5cc8797de771aa6ba234e06cc931520c:
Sandbox | Source |
---|---|
React | Configuration |
Attention: 69 lines
in your changes are missing coverage. Please review.
Comparison is base (
e0b8f12
) 84.86% compared to head (2f2e524
) 84.87%.
Files | Patch % | Lines |
---|---|---|
src/components/Carousel/Carousel.tsx | 39.47% | 69 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
SUMMARY:
size
prop and its enumCarouselSize
Large
,Medium
andSmall
, for now it only effects the buttons and their masks sizes, but may scale to effect other things in the futureButton
implementation to usevariant
propnextButtonProps
andpreviousButtonProps
to support even greater customization possibilitiesoverlayControls
prop with a default value oftrue
, enabling an option to either overlay the next/previous buttons or move them to either side of the scrollable list (Applicable totype
ofscroll
only).https://github.com/EightfoldAI/octuple/assets/99700808/b334a8ef-a672-4ada-8bab-9ec91f1cbe67
JIRA TASK (Eightfold Employees Only):
ENG-75830
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
andyarn storybook
. Verify theCarousel
stories behave as expected.