EightfoldAI / octuple

The Octuple component library
MIT License
16 stars 45 forks source link

feat: upload: adds delete button to single dropzones and other updates #775

Closed dkilgore-eightfold closed 5 months ago

dkilgore-eightfold commented 5 months ago

SUMMARY:

https://github.com/EightfoldAI/octuple/assets/99700808/fa541942-c79f-4b7c-acf5-afe3b0ff3289

JIRA TASK (Eightfold Employees Only):

ENG-75829

CHANGE TYPE:

TEST COVERAGE:

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the Upload stories behave as expected.

NOTE: This version does not include:

codesandbox-ci[bot] commented 5 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d127327e42494caf2e5c4ff0e59e8940ae08ffe5:

Sandbox Source
React Configuration
codecov[bot] commented 5 months ago

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (74bcec2) 84.86% compared to head (d127327) 84.81%.

Files Patch % Lines
src/components/Upload/UploadList/ListItem.tsx 55.88% 15 Missing :warning:
src/components/Upload/Upload.tsx 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #775 +/- ## ========================================== - Coverage 84.86% 84.81% -0.05% ========================================== Files 999 999 Lines 19496 19525 +29 Branches 7258 7281 +23 ========================================== + Hits 16546 16561 +15 - Misses 2870 2884 +14 Partials 80 80 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.