EightfoldAI / octuple

The Octuple component library
MIT License
17 stars 51 forks source link

fix: linkbutton: adjust anchor specificity to ignore bootstrap styles #776

Closed dkilgore-eightfold closed 8 months ago

dkilgore-eightfold commented 8 months ago

SUMMARY:

Currently, LinkButton picks up a few styles from Bootstrap, this change should prevent that happening.

https://github.com/EightfoldAI/octuple/assets/99700808/1ab2cea0-5c1a-4c3e-95d2-e82faf2d5911

JIRA TASK (Eightfold Employees Only):

ENG-76763

CHANGE TYPE:

TEST COVERAGE:

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify the LinkButton stories behave as expected. For further validation update your local vscode build that uses global Bootstrap CSS to reference the PR package and verify the styles.

codesandbox-ci[bot] commented 8 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d455e3d84026f1b4aba9724cc38201ed0a64df06:

Sandbox Source
React Configuration