Closed dkilgore-eightfold closed 5 months ago
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit e0ed60f8ee0ad0634c5afe08bbe78f44a65755b5:
Sandbox | Source |
---|---|
React | Configuration |
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
e27b733
) 84.81% compared to head (e0ed60f
) 84.82%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
SUMMARY:
Currently with every semver merged into vscode apps, the snapshot tests reflect a partial guid representing the function names in Octuple (e.g.
<Xw />
), this change ensures function names are not minified so the snaps should not need to be updated with each version bump.JIRA TASK (Eightfold Employees Only):
ENG-77343
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
andyarn storybook
. Verify components behave as expected. Then follow the steps in the internal wiki to create your own tarball, install is in vscode react project and run the project, then executenpm run test:update
Note that the function names are no longer minified and should persist from version to version. There may be one failing vscode unit test (DropdownWrapper), but that one is fixed, pending merge in v2.48.0 and is to be expected.