EightfoldAI / octuple

The Octuple component library
MIT License
16 stars 45 forks source link

fix: upstream: ensures upstream snaps do not minify function component names #779

Closed dkilgore-eightfold closed 5 months ago

dkilgore-eightfold commented 5 months ago

SUMMARY:

Currently with every semver merged into vscode apps, the snapshot tests reflect a partial guid representing the function names in Octuple (e.g. <Xw />), this change ensures function names are not minified so the snaps should not need to be updated with each version bump.

JIRA TASK (Eightfold Employees Only):

ENG-77343

CHANGE TYPE:

TEST COVERAGE:

TEST PLAN:

Pull the PR branch and run yarn and yarn storybook. Verify components behave as expected. Then follow the steps in the internal wiki to create your own tarball, install is in vscode react project and run the project, then execute npm run test:update Note that the function names are no longer minified and should persist from version to version. There may be one failing vscode unit test (DropdownWrapper), but that one is fixed, pending merge in v2.48.0 and is to be expected.

codesandbox-ci[bot] commented 5 months ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e0ed60f8ee0ad0634c5afe08bbe78f44a65755b5:

Sandbox Source
React Configuration
codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (e27b733) 84.81% compared to head (e0ed60f) 84.82%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #779 +/- ## ======================================= Coverage 84.81% 84.82% ======================================= Files 999 999 Lines 19525 19528 +3 Branches 7281 7281 ======================================= + Hits 16561 16565 +4 + Misses 2884 2883 -1 Partials 80 80 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.