Closed dkilgore-eightfold closed 5 months ago
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit bf01288c9ed2b2ec24afa2cac238c4096b2eba4c:
Sandbox | Source |
---|---|
React | Configuration |
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
4d1d324
) 84.83% compared to head (bf01288
) 84.84%. Report is 1 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
SUMMARY:
direction
prop forhorizontal
orvertical
support tostat
variant
fullWidth
prop supportvertical'
stat`maxWidth
prop support forstat
variant
lineClamp
prop forstat
variant
stat
so they properly handle no border and no divider scenarios as well as map to the latest spec--stat-tab-border-radius-m: 40px;
--stat-tab-border-radius-s: 24px;
--stat-tab-border-radius-xs: 16px;
https://github.com/EightfoldAI/octuple/assets/99700808/4107d4fa-8dc2-4c5b-9f1a-bb5b52a010c6
JIRA TASK (Eightfold Employees Only):
ENG-77353
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
andyarn storybook
. Verify theTabs
andStat Tabs
stories behave as expected.