Closed dkilgore-eightfold closed 4 months ago
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Attention: 177 lines
in your changes are missing coverage. Please review.
Comparison is base (
e828a69
) 84.83% compared to head (dc1ec70
) 84.37%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
SUMMARY:
linear-gradient
css variables and mappingsConfigProvider
to add aGradient
context andgradient
propConfigProvider
to add aTheme
contextstyleGenerator
to add gradient theme and individual scoped component theme containers supportAccordion
,Button
,Carousel
,Dialog
,InfoBar
,LinkButton
,Modal
,Pagination
,Panel
,PanelHeader
,Pill
,Snackbar
,Stepper
,Stat
, andUpload
Accordion
,Breadcrumb
,Button
,Carousel
,CheckBox
,Dialog
InfoBar
,Link
,LinkButton
,MatchScore
Modal
,Pagination
,Panel
,PanelHeader
,PersistentBar
,Progress
,RadioButton
,Tabs
,TextArea
,TextInput
,SearchBar
,Select
,Slider
,Snackbar
, andUpload
(Pill
SkillTag
,SkillBlock
,Stat
andStepper
use a less efficient legacy implementation - keeping 'as-is' for now)border-radius
is0
in fullscreenModal
Pill
component where theButton
counter was not being themed properly and its insets were wrongMenuItemButton
styles to align a bit better withButton
colorInvert
prop and its styles toTabs
pill
variant.ConfigProvider
storiesGradient
andTheme
context providers and their typesButton
where itscounter
spacing was too tight when there was no labelTwoStateButton
where its text color was usingaccent
palette instead ofbluegreen
themes.ts
so its arrays don't need to bereverse()
and the hexidecimal casing is in line with the modulesInfoBar
to usebackground
, rather thanbackground-color
InputStatus
to includehighlight
and applies updates status styles toTextArea
,TextInput
,SearchBar
,Select
,TimePicker
, andDatePicker
--violet-color-30
to match the design specificationButton
An example where a button was changed to
ButtonVariant.Primary
withgradient
,theme="blueViolet"
andconfigContextProps={{ noThemeContext: true }}
in a local test.Storybook https://github.com/EightfoldAI/octuple/assets/99700808/9222e250-f487-4f2b-8dc3-6277397fefdd
JIRA TASK (Eightfold Employees Only):
ENG-78260 ENG-78250 ENG-77347 ENG-77346 ENG-76044 ENG-76043 ENG-76042
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
Pull the PR branch and run
yarn
andyarn storybook
. Verify theConfigProvider
,Accordion
,Button
,Carousel
,CheckBox
,Dialog
,InfoBar
,Link
,LinkButton
,MatchScore
,Modal
,Pagination
,Panel
,PersistentBar
,Pill
,Progress
,RadioButton
,TextArea
,TextInput
,SearchBar
,Select
,Slider
,Snackbar
,Stepper
,Timeline
,Tabs
,TimePicker
,DatePicker
, andUpload
stories behave as expected.